Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

update modelmesh manifests to use 0.11.0 #939

Merged
merged 1 commit into from
Sep 26, 2023
Merged

update modelmesh manifests to use 0.11.0 #939

merged 1 commit into from
Sep 26, 2023

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Sep 22, 2023

Description

modelmesh/kserve synced with v0.11 so this odh-manifests needs to be updated.

How Has This Been Tested?

  • Install odh operator v2.x
  • add manifestsUri into DSCInitialization
apiVersion: dscinitialization.opendatahub.io/v1alpha1
kind: DSCInitialization
metadata:
  name: default
spec:
  applicationsNamespace: opendatahub
  manifestsUri: 'https://github.com/Jooho/odh-manifests/tarball/0.11'
  monitoring:
    enabled: false
    namespace: opendatahub
  • Create DSC
apiVersion: datasciencecluster.opendatahub.io/v1alpha1
kind: DataScienceCluster
metadata:
  labels:
    app.kubernetes.io/created-by: opendatahub-operator
    app.kubernetes.io/instance: default
    app.kubernetes.io/managed-by: kustomize
    app.kubernetes.io/name: datasciencecluster
    app.kubernetes.io/part-of: opendatahub-operator
  name: default
spec:
  components:
    codeflare:
      enabled: false
    dashboard:
      enabled: false
    datasciencepipelines:
      enabled: false
    kserve:
      enabled: false
    modelmeshserving:
      enabled: true
    ray:
      enabled: false
    workbenches:
      enabled: false
  • Create a ServingRuntime and deploy isvc
git clone git@github.com:opendatahub-io/modelmesh-serving.git
cd modelmesh-serving

STABLE_MANIFESTS=true CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving  make deploy-fvt-for-odh

oc apply -n modelmesh-serving -f https://raw.githubusercontent.com/opendatahub-io/modelmesh-serving/main/opendatahub/quickstart/common_manifests/openvino-serving-runtime.yaml

oc apply -n modelmesh-serving -f https://raw.githubusercontent.com/opendatahub-io/modelmesh-serving/main/opendatahub/quickstart/common_manifests/openvino-inference-service.yaml

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@Jooho
update modelmesh manifests to use 0.11.0
e67cdf7 
Signed-off-by: jooho <jlee@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jooho. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire
Copy link
Member

/retest

@VaishnaviHire
Copy link
Member

/retest

@Jooho Are these test failures expected?

@Jooho
Copy link
Contributor Author

Jooho commented Sep 25, 2023

@VaishnaviHire looks it failed with trustyAI part.

@Jooho
Copy link
Contributor Author

Jooho commented Sep 25, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

@Jooho: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-odh-manifests-e2e e67cdf7 link true /test 411-odh-manifests-e2e
ci/prow/odh-manifests-e2e e67cdf7 link true /test odh-manifests-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@VaishnaviHire
Copy link
Member

Merging this PR, as the modelmesh tests passed.

cc: @Jooho @heyselbi

@VaishnaviHire VaishnaviHire merged commit 6dd36fe into opendatahub-io:master Sep 26, 2023
3 of 6 checks passed
@heyselbi heyselbi mentioned this pull request Sep 26, 2023
Closed
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VedantMahabaleshwarkar VedantMahabaleshwarkar Awaiting requested review from VedantMahabaleshwarkar

@Xaenalt Xaenalt Awaiting requested review from Xaenalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jooho @VaishnaviHire